Skip to content

[HOI4]localisation closing quote check is lazy instead of greedy and uncommented text past the closing quote does not produce an error #74

Open

Description

@BiscuitCookies

localisation in hoi4 can use unescaped quotes inside the loc line and will take the last quote on the line as the closing quote
examples of valid and invalid loc in hoi4
l_english:
loc_key1: "this is valid loc"
loc_key2: "this is "also" valid loc"
loc_key3: "this is \"also\" valid loc"
loc_key4: "this is \"also valid loc"
loc_key5: "this is "also valid loc"
loc_key6: "this is invalid loc
loc_key7: this is invalid loc"
loc_key8: this is invalid loc
loc_key9: "this is valid loc" but with invalid stuff outside
loc_key10: "this is valid loc" #but with comment
loc_key11: "this is valid loc" #but this is also valid and read as part of the string due to quote after "

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions