Skip to content

Make machine-readable numeric formatting locale-independent - #3431

Open
appleweiping wants to merge 1 commit into
castorini:masterfrom
appleweiping:fix/locale-independent-output-3427
Open

appleweiping wants to merge 1 commit into
castorini:masterfrom
appleweiping:fix/locale-independent-output-3427

Conversation

@appleweiping

Copy link
Copy Markdown

Summary

  • use Locale.ROOT for TREC rows, generated document IDs, shard filenames, numeric TSV exports, test URLs, and generated documentation
  • replace tests that forced Locale.US with regression coverage under mzn-Arab-IR and de-DE
  • restore every temporary default-locale change in finally

Testing

  • mvn -B clean package -Dslf4j.internal.verbosity=WARN with Temurin 21 on Ubuntu: 1,162 tests passed
  • targeted locale-related suite: 83 tests passed
  • documentation generation: 12 tests passed under each locale, with identical SHA-256 hashes for all 780 generated files
  • git diff --check

Fixes #3427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make machine-readable numeric formatting locale-independent

1 participant