Repository navigation
Add Programmable Tokens page - #913
Merged
katomm merged 6 commits intoOct 5, 2026
Merged
Conversation
katomm
requested changes
Oct 2, 2026
Member
There was a problem hiding this comment.
Thanks Aldo, the page is well structured and the i18n wiring is clean. Before we can merge, a few things need attention.
Content accuracy
- KYC FAQ: allow-listed users are described as "not allowed to hold, send, or receive". That reads inverted.
- CIP-0143 credit: the CIP lists Philip DiSarro, the repo README credits "Phil DiSarro and the IOG team". We probably want to match that.
- "Bank of International Settlements" should be "Bank for International Settlements" (two places). The sentence "Not a manual check and not a permissioned wrapper" appears twice.
- Please replace the em and en dashes in the copy with commas, colons or periods, per the style guide.
Logo strip
- The strip under the hero shows Eternl, GeroWallet, CardanoScan, BloxBean and BendingAI without a visible label (only the screen reader label calls them "partners and users"). Partners of whom? Visitors will read it as these projects supporting programmable tokens today. I wonder if this is the right way to do it, also please see my next point.
- How is this strip meant to be maintained going forward? Do we add every project that implements CIP-113, and if so, what is the bar (mainnet integration, a public announcement, something else) and who decides? Without clear criteria the strip will either go stale or turn into a selection we cannot justify.
Assets
- Please don't create a page-named folder for assets that are shared by nature. Company logos go into
static/img/logos/<slug>.svgplus<slug>-dark.svgas vectors, so other pages can reuse them. - There is already a noise texture at
static/img/layer-2/noise.png. Please reuse one texture (we can move it to a shared location) instead of adding a second. - The six orb SVGs are single translucent circles, a CSS radial gradient would do the same without extra files.
- Open graph image is missing.
Components and styling
- The three call-to-action buttons are custom styles with fixed colors and no dark-mode handling, so they look different from the rest of the site and do not follow the theme. Please use the standard
button button--primary button--lgclasses (orCtaOneColumnfor a white button on a blue band), as on the other pages. The same applies to the bands behind them, which keep their light-mode colors in dark mode. - The
HorizontalScrollerpadding change applies to every carousel on the site (apps, categories, events). Please confirm those still look right, or scope the change to this page. - We already have
FAQSectionandGovernanceFAQ. Could the FAQ use one of them rather than a newAccordion?
Happy to help with any of this.
Member
|
Thanks for the quick round, Aldo. The asset cleanup, the shared noise texture, the CSS orbs, the reverted Content
Logo strip
Components and styling
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
yarn buildafter adding my changes without getting any errors.yarn.lock.Updating documentation or Bugfix
Following provided design by CFs team, adding the Programmable Tokens page