docs(slider): add custom marker labels example - #10997
Closed
salehghotbani wants to merge 1 commit into
Closed
salehghotbani wants to merge 1 commit into
salehghotbani wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Collaborator
|
Thanks a lot for these examples! 🙏 To make review easier we've consolidated them into #11001, where your commits are preserved. Closing this in favor of that one. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Add an example demonstrating direct composition and customization of
Slider.MarkerLabel.⛳️ Current behavior (updates)
The Slider documentation demonstrates the
Slider.Marksshortcut, but it does not show how to compose marker parts directly when each marker requires individual styling.🚀 New behavior
A new Custom Marker Labels example composes:
Slider.MarkerGroupSlider.MarkerSlider.MarkerIndicatorSlider.MarkerLabelEach marker label is styled independently to represent low, medium, and high threshold values.
💣 Is this a breaking change (Yes/No):
No.
📝 Additional Information
The existing
Slider.Marksexamples remain unchanged. This example documents the lower-level composition API without adding dependencies.The PR appears safe to merge with no actionable correctness or quality issues identified.
Summary
Reviews (1) · Last reviewed commit: "docs(slider): add custom marker labels e..."