docs(action-bar): document root props - #11002
Adebesin-Cell wants to merge 2 commits into
Conversation
Generate the root props type entry for ActionBar so the props table renders in the docs.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
This feels wrong to remove all the other parts. Please check the code to see if other parts are exported, then their props should be exposed as well.
There was a problem hiding this comment.
Yeah, those (Anchor, Arrow, ArrowTip, Description, Indicator, Title, Trigger) are Popover parts, not ActionBar parts; they only show up because arkPropsMap maps action-bar → popover and pulls in the whole set.
I did try dropping non-exported parts automatically instead of hardcoding, but it breaks ~15 other components; it looks like we lean on documenting Ark parts that the namespace doesn't re-export (Field shows Input/Select/Textarea even though field/namespace.ts doesn't). ActionBar's the only one wrapping a subset, so the manual removal feels like the safe call here.
Closes #
📝 Description
Adds the
ActionBarroot props to the generated types so the props table renders on the docs page.⛳️ Current behavior (updates)
The ActionBar root props table was empty because the type entry was not generated.
🚀 New behavior
generate-typesnow emits the root props entry for ActionBar, and the docs page picks it up.💣 Is this a breaking change (Yes/No):
No
📝 Additional Information
The PR appears safe to merge; the documentation lookup and generated metadata match the ActionBar public API.
Summary
ActionBar.Rootinstead ofPopover.Root.positioning, which the publicActionBarRootPropstype explicitly omits.Reviews (1) · Last reviewed commit: "docs(action-bar): document root props"