Conversation
The CLI claimed max_concurrent_trials was passed to Ray TuneConfig, but tune_model only used it to divide CPU/GPU resources when num_cpus/gpus were also set. Pass it through TuneConfig so concurrency is honored (e.g. =1 for sequential trials), validate non-positive values, and add a unit regression for chemprop#1402.
Member
|
Hi @castor639, thanks for the PR. Several users are reporting issues using Ray. Have you had success using Ray with Chemprop recently? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI claimed max_concurrent_trials was passed to Ray TuneConfig, but tune_model only used it to divide CPU/GPU resources when num_cpus/gpus were also set. Pass it through TuneConfig so concurrency is honored (e.g. =1 for sequential trials), validate non-positive values, and add a unit regression for #1402.
Description
Include a brief summary of the bug/feature/etc. that this PR seeks to address
Example / Current workflow
Include a sample workflow to either (a) reproduce the bug with current codebase or (b) showcase the deficiency does this PR seeks to address
Bugfix / Desired workflow
Include either (a) the same workflow from above with the correct output produced via this PR (b) some (pseudo)code containing the new workflow that this PR will (seek to) implement
Questions
If there are open questions about implementation strategy or scope of the PR, include them here
Relevant issues
If appropriate, please tag them here and include a quick summary
Checklist