Migrate to pydantic 2.0+ - #73
Merged
Merged
Conversation
Contributor
Author
|
@kaminow could I grab a review here? This should allow us to migrate nicely and unblock downstream, but please double check everything still works as expected for configs. |
kaminow
approved these changes
Oct 10, 2024
kaminow
left a comment
Collaborator
There was a problem hiding this comment.
one thing to address but otherwise looks good. thanks for doing this!
| values[p] = values[p] * num_layers | ||
|
|
||
| return values | ||
| return self.__dict__.update(values) |
Collaborator
There was a problem hiding this comment.
I don't think update actually returns anything
Suggested change
| return self.__dict__.update(values) | |
| self.__dict__.update(values) | |
| return self.__dict__ |
Contributor
Author
There was a problem hiding this comment.
Now that you mention it we should return self
Contributor
Author
There was a problem hiding this comment.
this is due to how the after mode validator works in pydantic 2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #72
Status