Skip to content

Add split handling for ligand and protein representations - #78

Merged
kaminow merged 77 commits into
mainfrom
add-split-model
May 19, 2025
Merged

Add split handling for ligand and protein representations#78
kaminow merged 77 commits into
mainfrom
add-split-model

Conversation

@kaminow

@kaminow kaminow commented Mar 20, 2025

Copy link
Copy Markdown
Collaborator

We'd like to be able to treat the ligand and the complex/protein structures separately when making predictions rather than passing everything through the same model, since the current method of treating the ligand with the same large, structure-based model may not be ideal.

@codecov-commenter

codecov-commenter commented Apr 11, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 19.79592% with 393 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.95%. Comparing base (40299e8) to head (4ced2c4).
⚠️ Report is 79 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (40299e8) and HEAD (4ced2c4). Click for more details.

HEAD has 12 uploads less than BASE
Flag BASE (40299e8) HEAD (4ced2c4)
unittests 18 6
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kaminow
kaminow requested a review from hmacdope April 18, 2025 19:45
@kaminow

kaminow commented Apr 18, 2025

Copy link
Copy Markdown
Collaborator Author

@hmacdope I think this may actually be ready for a review when you get the chance! happy to meet at some point and walk through things as well

@hmacdope

Copy link
Copy Markdown
Contributor

@kaminow I'm probably not going to have time to review, I trust your judgement here.

@kaminow
kaminow force-pushed the add-split-model branch from cc57795 to d89db4e Compare May 19, 2025 15:03
@kaminow
kaminow force-pushed the add-split-model branch from d89db4e to e70712c Compare May 19, 2025 15:14
@kaminow

kaminow commented May 19, 2025

Copy link
Copy Markdown
Collaborator Author

Merging so we can proceed with choderalab/asapdiscovery merging.

@kaminow
kaminow merged commit c1fa19a into main May 19, 2025
@kaminow
kaminow deleted the add-split-model branch May 19, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants