fix: lookup of nesting addresses - #402
Merged
Merged
Conversation
BREAKING CHANGE: a reparse is required to fix the nesting address index
addressesToSearch.begin() is not consistent across architectures
maltemoeser
force-pushed
the
fix/nesting-index
branch
from
May 7, 2020 15:23
0e1f85e to
6e9423f
Compare
Member
Author
|
Not sure why Travis is failing, seems to build fine locally and on CircleCI. |
Collaborator
|
Merged already, but still: had a closer look today. Looks good to me. 👍 |
Member
Author
|
@mplattner thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The index to look up which addresses wrap another address was never correctly created (it used
txFirstSeeninstead oftxFirstSpent). In addition, multisig addresses can be wrapped by multiple (different) scripthash addresses (due to the order in which keys appear in the script).Requires a reparse to correctly build the index.
Required checks: