Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent positive Actor definition references from being looked up as string-table offsets. When a fragment index happens to equal an occupied string offset,
ObjectLocation::model_name()can otherwise return an unrelated model name.Return
Nonefor the unsupported positive fragment-reference form and document the limitation. Preserve existing nonpositive lookup behavior, including zero. Keep the parser's raw field, public method signature and generic string lookup unchanged; this does not implement Actor-definition graph resolution.Fixes djhenry#11.
Validation:
useless_borrows_in_formattingwarnings. The same failures reproduce without this change; tracked in Fix WLD Clippy errors on Rust 1.98 djhenry/libeq#6. WLD all-target Clippy passes when only that existing lint is allowed.This is library-level validation; no native-asset or live-client validation is claimed.
This contribution is based on upstream main and contains no unrelated fork changes. It does not update an asset-server dependency pin or activate client behavior. The baker's separate raw lookup is tracked in djhenry/eqoxide_asset_server#96.