Repository navigation
fix: identify the setting each reset button affects - #2253
Open
johnjheejin wants to merge 2 commits into
Open
johnjheejin wants to merge 2 commits into
johnjheejin wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before Submitting This PR
Please submit only one fix or feature per pull request. Pull requests containing multiple fixes or features will likely be closed.
Please confirm you have done the following:
If this is a feature or change that was previously closed/rejected:
Not applicable: no previously closed or rejected change is being reopened.
Human Written Description
I'm continuing to look for small ways to contribute to Handy. I wanted the reset buttons to say which setting they affect, so people using screen readers can tell them apart.
Related Issues/Discussions
No issue is being closed. Related to #2238, which names the checkbox and range controls themselves. This PR names the separate reset actions for sliders, microphone/output selectors, the laptop clamshell microphone, recognition language, and both shortcut input backends.
The callers use the existing
ResetButton.ariaLabelprop with the translated setting title. The reset-action key is present in all 26 locale files. English and Korean have action text in those languages; the other locales use an English action string with their translated setting names. The model-list refresh button retains its existing custom label.Community Feedback
No separate community feedback was gathered for this reset-button accessibility fix.
Testing
node --experimental-strip-types scripts/check-translations.ts. Every locale has the new key and preserves{{setting}}.git diff --checkpassed.Screenshots/Videos (if applicable)
Not included: this adds accessible names without visual layout changes.
AI Assistance
If AI was used: