feat: add tiered pricing for gemini-2.5-pro by monotykamary · Pull Request #2741 · cline/cline

monotykamary · 2025-04-08T14:51:08Z

Description

This PR introduces tiered pricing calculation and display for the gemini-2.5-pro-preview-03-25 model based on input token count.

Changes:

src/shared/api.ts:
- Added a PriceTier interface.
- Updated ModelInfo to include optional inputPriceTiers and outputPriceTiers arrays.
- Modified the gemini-2.5-pro-preview-03-25 definition to use these tiers, reflecting the $1.25/$2.50 input and $10.00/$15.00 output pricing based on a 200k input token threshold.
src/utils/cost.ts:
- Refactored calculateApiCostInternal to determine effective input/output prices based on tiers if available, using a new totalInputTokensForPricing parameter.
- Updated calculateApiCostOpenAI to pass the total input tokens for tier lookup.
webview-ui/src/components/settings/ApiOptions.tsx:
- Updated ModelInfoView to display tiered pricing clearly, with each tier on a new indented line.
- Refactored rendering logic to use <span> and Fragment for better layout and spacing control.

Test Procedure

Select "Google Gemini" as the API Provider in settings.
Choose the gemini-2.5-pro-preview-03-25 model.
Observe the "Model Info" section below the dropdown.
Verify that the Input and Output prices are displayed with two tiers each:
- Input: <= 200k tokens ($1.25/M) and > 200k tokens ($2.50/M)
- Output: <= 200k tokens ($10.00/M) and > 200k tokens ($15.00/M) (based on input tokens)
Verify the formatting matches the final screenshot (compact spacing).
(Optional) If possible, trigger API calls with prompts below and above 200k tokens and verify the cost calculation reflects the correct tier pricing in any relevant logs or usage tracking.

Type of Change

🐛 Bug fix (non-breaking change which fixes an issue)
✨ New feature (non-breaking change which adds functionality)
💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
📚 Documentation update

Pre-flight Checklist

Changes are limited to a single feature, bugfix or chore (split larger changes into separate PRs)
Tests are passing (npm test) and code is formatted and linted (npm run format && npm run lint) (Based on pre-commit hook success)
I have created a changeset using npm run changeset (Required for user-facing changes - Please run this if needed)
I have reviewed contributor guidelines

Screenshots

Final UI showing tiered pricing for Gemini model in settings.

Additional Notes

This change generalizes the pricing structure to support future models with tiered costs.

changeset-bot · 2025-04-08T14:51:13Z

⚠️ No Changeset found

Latest commit: 2381fcd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ellipsis-dev

❌ Changes requested. Reviewed everything up to f5a9949 in 2 minutes and 59 seconds

More details

Looked at 246 lines of code in 3 files
Skipped 0 files when reviewing.
Skipped posting 6 drafted comments based on config settings.

1. src/utils/cost.ts:15

Draft comment:
Assumes tiers are sorted in ascending order by tokenLimit. Consider verifying/sorting them to ensure correct tier lookup.
Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50%
The comment identifies a real potential issue - unsorted tiers could lead to incorrect pricing. However, this seems like something that should be validated when creating/setting the tiers, not every time we look them up. The comment also doesn't provide clear direction on where/how to implement the validation.
The issue could be serious if it leads to incorrect pricing. The suggestion to sort tiers could be a valid solution.
While pricing correctness is important, this validation belongs at the data layer where tiers are defined/loaded, not in the cost calculation function. The current comment location puts the fix in the wrong place.
Delete the comment because it suggests adding validation in the wrong place and doesn't provide clear, actionable guidance.

2. webview-ui/src/components/settings/ApiOptions.tsx:1608

Draft comment:
The tiered pricing rendering code assumes inputPriceTiers (and similarly outputPriceTiers) are provided in the expected sorted order. Consider adding a comment or safeguard if order isn’t guaranteed.
Reason this comment was not posted:
Comment looked like it was already resolved.

3. src/utils/cost.ts:15

Draft comment:
The non-null assertion on totalInputTokensForPricing is safe due to the preceding check, but consider omitting '!' for clarity.
Reason this comment was not posted:
Confidence changes required: 50% <= threshold 50%
None

4. webview-ui/src/components/settings/ApiOptions.tsx:1564

Draft comment:
Avoid hard-coding the callback URL domain ('saoudrizwan.claude-dev') in getOpenRouterAuthUrl; consider externalizing or parameterizing for production use.
Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.

5. webview-ui/src/components/settings/ApiOptions.tsx:1605

Draft comment:
The check for Gemini models uses Object.keys(geminiModels).includes(selectedModelId). Using the provider value (e.g. selectedProvider === 'gemini') might be more robust.
Reason this comment was not posted:
Comment was on unchanged code.

6. webview-ui/src/components/settings/ApiOptions.tsx:1577

Draft comment:
The tier formatting helper (formatTiers) is well written; consider memoizing its result if the tiers rarely change, to optimize re-renders.
Reason this comment was not posted:
Confidence changes required: 50% <= threshold 50%
None

Workflow ID: wflow_U6EcK3Y5j56HvT7K

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

- Clarify token limit display using full numbers instead of 'k'. - Specify price unit as '/million tokens' for better understanding.

saoudrizwan · 2025-04-09T02:15:49Z

thank you 🙏

* feat: add tiered pricing for gemini-2.5-pro * fix: ensure price tiers are sorted before lookup * refactor: remove old prices * refactor(settings): improve model tier pricing display clarity - Clarify token limit display using full numbers instead of 'k'. - Specify price unit as '/million tokens' for better understanding.

feat: add tiered pricing for gemini-2.5-pro

f5a9949

monotykamary requested review from NightTrek, dcbartlett, ocasta181, pashpashpash, saito-sv and saoudrizwan as code owners April 8, 2025 14:51

ellipsis-dev Bot reviewed Apr 8, 2025

View reviewed changes

Comment thread src/utils/cost.ts Outdated

Comment thread src/shared/api.ts

monotykamary added 3 commits April 8, 2025 22:00

fix: ensure price tiers are sorted before lookup

64f7e05

refactor: remove old prices

2381fcd

refactor(settings): improve model tier pricing display clarity

1141753

- Clarify token limit display using full numbers instead of 'k'. - Specify price unit as '/million tokens' for better understanding.

frostbournesb self-requested a review April 9, 2025 01:27

frostbournesb approved these changes Apr 9, 2025

View reviewed changes

frostbournesb requested a review from arafatkatze April 9, 2025 01:28

dcbartlett approved these changes Apr 9, 2025

View reviewed changes

arafatkatze reviewed Apr 9, 2025

View reviewed changes

Comment thread src/utils/cost.ts

arafatkatze requested changes Apr 9, 2025

View reviewed changes

Comment thread webview-ui/src/components/settings/ApiOptions.tsx

dcbartlett requested review from arafatkatze and dcbartlett April 9, 2025 02:03

dcbartlett approved these changes Apr 9, 2025

View reviewed changes

arafatkatze approved these changes Apr 9, 2025

View reviewed changes

dcbartlett merged commit b470229 into cline:main Apr 9, 2025

Navigation Menu

Repository navigation

feat: add tiered pricing for gemini-2.5-pro - #2741

feat: add tiered pricing for gemini-2.5-pro#2741
dcbartlett merged 4 commits into
cline:mainfrom
monotykamary:feat/gemini-tiered-pricing

monotykamary commented Apr 8, 2025 •

edited

Loading

Uh oh!

changeset-bot Bot commented Apr 8, 2025 •

edited

Loading

Uh oh!

ellipsis-dev Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

saoudrizwan commented Apr 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

monotykamary commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Test Procedure

Type of Change

Pre-flight Checklist

Screenshots

Additional Notes

Uh oh!

changeset-bot Bot commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

ellipsis-dev Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

saoudrizwan commented Apr 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

monotykamary commented Apr 8, 2025 •

edited

Loading

changeset-bot Bot commented Apr 8, 2025 •

edited

Loading