Skip to content

support migration with proto descriptors file - #145

Merged
sinmetal merged 5 commits into
cloudspannerecosystem:masterfrom
rail44:proto-descriptor
Jun 16, 2025
Merged

support migration with proto descriptors file#145
sinmetal merged 5 commits into
cloudspannerecosystem:masterfrom
rail44:proto-descriptor

Conversation

@rail44

@rail44 rail44 commented Jun 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

WHAT

  • Added --proto_descriptor_file flag to apply, create, load, and migrate up commands
  • Extended core Client methods to accept and handle proto descriptor data alongside DDL operations
  • Modified LoadDDL to return both schema and proto descriptors from existing databases
  • Added test for implemented features

WHY

Protocol buffer support is essential for Cloud Spanner applications using proto columns and message types. This feature enables users to:

  • Create and modify proto-enabled databases with proper message definitions
  • Migrate schemas that include proto column types
  • Load existing proto descriptors from databases for backup/export workflows
  • Maintain consistency between application proto definitions and database schema

@google-cla

google-cla Bot commented Jun 4, 2025

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@rail44
rail44 marked this pull request as ready for review June 4, 2025 14:24
@zchee

zchee commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

cc: @vvakame @sinmetal

@sinmetal

sinmetal commented Jun 14, 2025

Copy link
Copy Markdown
Collaborator

LGTM

@rail44 Thank you for your contribution.
I had a conflict when merging another PR, so could you please fix it?

@rail44

rail44 commented Jun 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@sinmetal
Thank you too for reviewing.
I've fixed conflict. I hope you will check again 🙏

@sinmetal
sinmetal self-requested a review June 16, 2025 05:33
@sinmetal
sinmetal merged commit 6563aca into cloudspannerecosystem:master Jun 16, 2025
@robpryan robpryan mentioned this pull request Sep 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sinmetal sinmetal sinmetal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rail44 @zchee @sinmetal