Skip to content

v0.9.4 rate limiter may be broken #62

Open

Description

@cnguy

After integrating this, #59, I did quick testing but didn't re-run all my examples to verify that the library still works properly. The hanging was solved, but batch promises don't seem to resolve via Promise.all.

For now stay on v0.9.3 or upgrade to v0.9.5 (they are the same things). v0.9.4 only introduces this hanging change.

What basically happens is the first promise of Promise.all will resolve, but the rest will not be resolved (in debug, the first request will be a success, while the rest are ignored, and then the process resolves).

For now I'll revert the change for v0.9.5 to prevent new install issues.

Activity

  1. jamesaps commented on Jan 30, 2019

    @jamesaps

    Any update on this?

  2. cnguy commented on Jan 31, 2019

    @cnguy
    OwnerAuthor

    this will be revisited on the weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions