Merged
Conversation
added 2 commits
November 25, 2025 17:17
- Remove LLM-generated openssl_fix.rb script - Remove debug files (error.log, output.txt) - Update sidebar_htmltest.rb to respect htmltest config and skip archived versions This addresses issues similar to those found in PR #21195 for v2.1: - Removes SSL workaround script that doesn't belong in src/current - Removes accidentally committed build artifacts - Ensures htmltest skips archived versions during validation
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
Files changed:
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
rmloveland
requested changes
Dec 11, 2025
| gem "webrick" | ||
| gem "jekyll-minifier" | ||
|
|
||
| gem "csv" |
Contributor
There was a problem hiding this comment.
gemfile changes should go in a separate PR
| @site = site | ||
|
|
||
| # Read htmltest configuration to get ignored directories | ||
| htmltest_config = YAML.load_file('.htmltest.yml') rescue {} |
Contributor
rmloveland
approved these changes
Dec 19, 2025
Contributor
rmloveland
left a comment
There was a problem hiding this comment.
@ebembi-crdb this LGTM once you implement the changes I mentioned in the comments. Wanted to unblock you on this since I will be on PTO for the holidays next week
added 11 commits
December 22, 2025 16:56
- Add v20.2 offline documentation link to archived documentation page - Remove v20.2 specific files from repository including: - src/current/v20.2/ directory - src/current/_includes/sidebar-data-v20.2.json - src/current/images/v20.2/ directory - Resolve merge conflicts with main branch - Revert Gemfile changes per review feedback
The build requires jekyll-minifier gem. Will be removed in separate PR as requested in review.
- Resolved merge conflicts in archived-documentation.md - Removed v20.2/cockroach-start.md (archiving v20.2) - Fixed broken links to v20.2 topology documentation
- Resolved merge conflicts by confirming deletion of v20.2 files - Fixed broken v20.2 geospatial image references by updating to each version's own images - Preserved v21.1 documentation files on this branch - Updated archived-documentation.md to include both v21.1 and v20.2
Add missing destination-file-privileges.md include file for v21.1 by copying from v21.2 to fix build error
Resolved conflicts by: - Keeping v21.2 documentation files on this branch (only archiving v20.2) - Not adding v21.2 to archived-documentation.md (v21.2 still active on this branch) - Accepting deletion of v21.2 release include files from main
Add missing diagram files for v21.1 documentation: - backup.html - restore.html These files are required by v21.1/backup.md and v21.1/restore.md Copied from v20.2/sql/diagrams to v21.1/sql/generated/diagrams
v21.1 was already archived on main, so it should also be deleted on this branch to avoid build failures. This replaces the incorrect approach of creating missing v21.1 includes. Following the proper archival pattern from successful PRs: - Delete ALL files for archived versions - Don't patch other versions with missing includes
v21.2 was already archived on main, so it should also be deleted on this branch to avoid build failures with missing includes. Following the proper archival pattern: - Delete ALL files for archived versions - Don't patch other versions with missing includes
Resolved merge conflicts: - Deleted v22.2 files that were already archived on main - Updated archived-documentation.md to include v22.2 and v21.2 entries - Deleted v21.2 files to avoid build failures (already archived on main)
Resolved merge conflicts: - Deleted v22.1 files that were already archived on main - Removed conflicting v22.1 includes and documentation files
This was referenced Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Archives v20.2 documentation following the same process used for v2.1.
Changes