fix: Add types to avoid PHP 8.2 deprecation warning - #322
Merged
Merged
Conversation
florianeckerstorfer
approved these changes
Jul 31, 2023
Author
|
Thanks!! @florianeckerstorfer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi team,
I wanted to let you know about a deprecation warning I've been getting in all my projects since updating to PHP 8.2. The warning is related to using nullable types instead of strings.
Here's the link to the PHP 8.1 deprecation notice: link
To address this, I think we should improve the types used in the slugify method, but it would be a breaking change.
Another option is to check for null at the beginning of the method and return an empty string in that case. However, I'm not sure if this is the best solution.
Please share your thoughts on whether this approach is correct or if you have any other ideas.
Thanks.