Skip to content

Add Sphere Utility tool - #7

Merged
cohaereo merged 1 commit into
cohaereo:lightfallfrom
Froggy618157725:sphere_tool
Jan 7, 2024
Merged

cohaereo merged 1 commit into
cohaereo:lightfallfrom
Froggy618157725:sphere_tool

Conversation

@Froggy618157725

Copy link
Copy Markdown
Collaborator

Draws a sphere at the given location. Defaults to 9m because it'll probably be most useful for spawn point manipulation.

Also added a circle for debug shapes to give the sphere a bit more skeleton.

Refactored line drawing to be it's own function so it's easier to reuse.

@cohaereo
cohaereo self-requested a review January 7, 2024 11:10

@cohaereo cohaereo left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice for a first feature 👌
One last request after you fix the other comments is to run cargo fmt to reformat the code before you push.

Comment thread src/render/debug.rs Outdated
Comment thread src/ecs/component_panels.rs Outdated
Comment thread src/ecs/component_panels.rs Outdated
Comment thread src/ecs/component_panels.rs Outdated
Draws a sphere at the given location. Defaults to 9m because it'll probably be
most useful for spawn point manipulation.

Also added a circle for debug shapes to give the sphere a bit more skeleton.

Refactored line drawing to be it's own function so it's easier to reuse.

@cohaereo cohaereo left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cohaereo
cohaereo merged commit 8c5cff5 into cohaereo:lightfall Jan 7, 2024
@Froggy618157725
Froggy618157725 deleted the sphere_tool branch January 13, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants