Change JDK version to 21#67
Open
fkleedorfer wants to merge 2 commits into
Open
Conversation
The formatting style option `preserveBlankNodeLabelsAndOrdering` is added that governs whether the ordering and labels of blank nodes found in the source document is to be used or overriden according to the result of the stable blank node ordering algorithm. When `false` rdf parsing is done without using the blank node aware parser necessary for preserving ordering and labels.
The formatting style option `preserveBlankNodeLabelsAndOrdering` is added that governs whether the ordering and labels of blank nodes found in the source document is to be used or overriden according to the result of the stable blank node ordering algorithm. When `false` rdf parsing is done without using the blank node aware parser necessary for preserving ordering and labels.
Contributor
Author
|
Seems to work! @atextor would you be open to lowering the JDK version? |
Collaborator
|
The code base currently does not strongly depend on Java 25 features, so the downgrade should work in theory. However, since I was going to start playing around with features and/or dependencies that indeed require 25, I'd like to make sure how we can approach this in the longterm. I'd like to support the Spotless usecase, but (somehow) at the same time don't be dependent on their update roadmap. Do we known if/when Spotless is rather going to update to 25? It is the latest LTS release after all and was already released almost a year ago. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Cool-RDF builds for JDK 25, But I am not convinced it's required. Users of the RDF formatter in the spotless plugin would be less disrupted if they did not need to update their JDK when updating. This PR just blindly tries if it would work Local build fails at diagram generation bc it does not find dot, but that should not be an issue here.