Skip to content

fix(ui): improve highlighted button and spinner contrast - #11279

Merged
peaklabs-dev merged 3 commits into
coollabsio:mainfrom
fsioni:fix-highlighted-button-contrast
Aug 18, 2026
Merged

peaklabs-dev merged 3 commits into
coollabsio:mainfrom
fsioni:fix-highlighted-button-contrast

Conversation

@fsioni

@fsioni fsioni commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Use the computed accent foreground for highlighted buttons so custom light themes receive dark text while dark themes retain white text.
  • Make the unsaved changes Enter shortcut inherit its button foreground, border, and tint instead of using fixed purple and white values.
  • Add regression coverage for highlighted-button and keyboard-shortcut contrast.

Issues

  • Fixes the unreadable Enter shortcut and highlighted-button labels reported with some theme colors.

Category

  • Bug fix
  • Improvement
  • New feature
  • Adding new one click service
  • Fixing or updating existing one click service

Preview

Before

Before: the Enter shortcut has insufficient contrast

After

After: the Enter shortcut inherits the readable button foreground

Theme contrast gallery

Theme contrast gallery across 12 colors

AI Assistance

  • AI was NOT used to create this PR
  • AI was used (please describe below)

If AI was used:

  • Tools used: OpenAI Codex
  • How extensively: Used for diagnosis, implementation, automated tests, a 12-theme visual contrast matrix, and PR preparation. The changes were reviewed and tested by the contributor on a local Coolify instance.

Testing

  • Ran the focused Pest suite: 24 tests passed with 103 assertions.
  • Ran the Vite production build successfully.
  • Verified the real unsaved changes bar on a local Coolify instance.
  • Checked 12 light and dark custom theme colors in a browser; the button and shortcut foreground matched in every case.

Contributor Agreement

Important

  • I have read and understood the contributor guidelines. If I have failed to follow any guideline, I understand that this PR may be closed without review.
  • I have searched existing issues and pull requests (including closed ones) to ensure this isn't a duplicate.
  • I have tested all the changes thoroughly with a local development instance of Coolify and I am confident that they will work as expected when a maintainer tests them.

Copilot AI lite review requested due to automatic review settings August 14, 2026 13:19

This comment was marked as spam.

@peaklabs-dev peaklabs-dev changed the title fix(ui): improve highlighted button contrast fix(ui): improve highlighted button and spinner contrast Aug 18, 2026

@peaklabs-dev peaklabs-dev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

@peaklabs-dev
peaklabs-dev merged commit c2b7978 into coollabsio:main Aug 18, 2026
1 check passed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants