fix(database): tighten Postgres init script filename handling - #9681
Merged
Merged
Conversation
Validate new init-script filenames against path traversal and shell metacharacters via a new validateFilenameSafe() helper, and harden the write/delete paths with basename() + escapeshellarg() so legacy rows still deploy and can be cleaned up without regressions. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validateFilenameSafe()helper inbootstrap/helpers/shared.phpthat rejects directory separators, traversal sequences, null bytes, glob/tilde/quote chars, and inherits all shell-metachar checks fromvalidateShellSafePath().app/Livewire/Project/Database/Postgresql/General.php.StartPostgresql::generate_init_scripts()and the Livewire delete path) normalise legacy values withbasename()+escapeshellarg()instead of hard-validating, so previously saved rows keep deploying and operators can still clean them up.Test plan
php artisan test --compact --filter=ValidateFilenameSafephp artisan test --compact --filter=PostgresqlInitScriptSecurityTestinit.sql) and deploy — file lands indocker-entrypoint-initdb.d/and the DB boots./,..,*, or a space — Livewire surfaces the validation error.🤖 Generated with Claude Code