Export mac binaries in CI #2700
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarlinpe
approved these changes
Aug 13, 2024
| config: [ | ||
| { | ||
| os: macos-14, | ||
| arch: arm64, |
Member
There was a problem hiding this comment.
Very cool! This creates a binary for arm64 only, would it make sense to also create a binary for intel machines? We can have another config with a macos-13 runner.
Contributor
Author
There was a problem hiding this comment.
One problem I have is that the binary doesn't seem to work under arm64. The changes in this PR work under x86 on my 10 year old macbook pro. If you have some minutes to investigate what's going wrong under arm64, that would be great. I don't have access to an arm64 machine.
Member
There was a problem hiding this comment.
I also don't have an arm64 machine at hand for now. Could we instead test the binary in a fresh arm64 runner in the CI?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.