-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Python scripts to write Pose Priors into a database from a given file. #2981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This is certainly useful, thank you! From now on, we want new Python code to live in pycolmap/pycolmap and to use the pycolmap APIs instead of the soon-deprecated database.py. Would you mind updating your code accordingly? Thanks again. |
|
Alright, no problem. I will look at it. |
|
Hey, do you think it's fine to keep the python script based on the soon to-be deprecated database.py file along with the pycolmap based script? |
| @@ -0,0 +1,152 @@ | |||
| """ | |||
| Python reimplementation of the C++ incremental mapper with equivalent logic. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is left over from copying another sample file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I forgot to remove this header comment.
|
Nice, will give this a try probably. I'm looking into upgrading our 3D reconstruction pipeline to pre-populate pose priors from ARKit poses, then feed the colmap DB into glomap which seems to have some support now for using pose priors. |
No description provided.