Skip to content

Conversation

@ferreram
Copy link
Contributor

@ferreram ferreram commented Dec 3, 2024

No description provided.

@sarlinpe
Copy link
Member

sarlinpe commented Dec 3, 2024

This is certainly useful, thank you! From now on, we want new Python code to live in pycolmap/pycolmap and to use the pycolmap APIs instead of the soon-deprecated database.py. Would you mind updating your code accordingly? Thanks again.

@ferreram
Copy link
Contributor Author

ferreram commented Dec 3, 2024

Alright, no problem. I will look at it.

@ferreram
Copy link
Contributor Author

Hey, do you think it's fine to keep the python script based on the soon to-be deprecated database.py file along with the pycolmap based script?

@@ -0,0 +1,152 @@
"""
Python reimplementation of the C++ incremental mapper with equivalent logic.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is left over from copying another sample file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I forgot to remove this header comment.

@robinlindh
Copy link

Nice, will give this a try probably. I'm looking into upgrading our 3D reconstruction pipeline to pre-populate pose priors from ARKit poses, then feed the colmap DB into glomap which seems to have some support now for using pose priors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants