Update FindMetis.cmake to also link GK_LIBRARIES #3470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
It appears that Docker, Mac, and Ubuntu were using a statically compiled GKlib in the metis library. I changed the file again so that both ways of linking should work. |
If GKlib is found, add libraries to METIS target
ahojnnes
approved these changes
Jul 14, 2025
Contributor
|
Thank you, LGTM. |
ahojnnes
added a commit
that referenced
this pull request
Jul 16, 2025
I might be missing something, but I was encountering missing symbols from GKlib during the linking stage. It seems like an oversight: FindMetis.cmake correctly locates the GKlib library, but it doesn't actually link it after finding it. This pull request adds GKlib to the list of linked libraries to resolve that issue. --------- Co-authored-by: Johannes Schönberger <jsch@demuc.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I might be missing something, but I was encountering missing symbols from GKlib during the linking stage. It seems like an oversight: FindMetis.cmake correctly locates the GKlib library, but it doesn't actually link it after finding it. This pull request adds GKlib to the list of linked libraries to resolve that issue.