Add random_seed option to RANSACOptions for reproducible TwoViewGeometry estimation #3492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahojnnes
reviewed
Jul 19, 2025
ahojnnes
reviewed
Jul 19, 2025
ahojnnes
reviewed
Jul 19, 2025
ahojnnes
reviewed
Jul 19, 2025
Contributor
ahojnnes
left a comment
There was a problem hiding this comment.
Thanks, LGTM apart from a few minor comments.
added 3 commits
July 21, 2025 09:16
0391e71 to
f527c0f
Compare
ahojnnes
approved these changes
Jul 21, 2025
|
Thanks for this contribution, I was just looking for this! Do you already know when this will be available as part of an official release? |
tavislocus
pushed a commit
to tavislocus/colmap_6dof
that referenced
this pull request
Aug 19, 2025
…try estimation (colmap#3492) This PR adds a `random_seed` parameter to `RANSACOptions` for deterministic results in multithreaded environments. - `random_seed = -1` (default) preserves the original nondeterministic behavior. - Setting it to a fixed value makes estimation deterministic and reproducible. - Currently applied and tested only in `TwoViewGeometry` estimation. --------- Co-authored-by: StonerLing <sisyphus.stoner@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
random_seedparameter toRANSACOptionsfor deterministic results in multithreaded environments.random_seed = -1(default) preserves the original nondeterministic behavior.TwoViewGeometryestimation.