Abstract database interface and sqlite implementation #3541
Conversation
|
Seems like the pybind smart_holder feature is only available in 3.0.0. I cannot make the python bindings work without it though. @sarlinpe FYI |
…h/database-interface
…h/database-interface
paulinus
left a comment
There was a problem hiding this comment.
LGTM. It is large, i hope i did not miss errors, but i imagine most would already be caught by the compiler since a lot of it was variable to pointer changes.
On the wrapper side, is it the case that you finally did not need to use py::trampoline_self_life_support because the Database objects are returned using shared pointers rather than unique pointers? I'm not familiar enough with wrapping abstract classes to understand if it is needed.
Yes, without the trampoline support (introduced by Pybind11 3.X), this was not easily possible. |
Introduces an abstract interface for the database, so we can support different implementations (e.g., Postgres/MySQL, key-value stores, etc.). New implementations can be registered statically.