Skip to content

incompatiblity: tx_search is reset to a single entry when using goleveldb with cometbft v0.38.x #4295

Description

@faddat

Goleveldb (not pebble) is broken when using tx_search with cometbft v0.38.12 and cometbft-db v0.13.0+

I don't know if this happens in main or not.

If users should not use cometbft-db > 0.12.x with cometbft v0.38.x, we should probably say that.

I think it is more likely that this breakage was unintentional, related to the contract changes mentioned in the release nodes for cometbft-db:

Note that users of cometbft v0.38.x may wish to use:

  • the latest pebble
  • the latest rocksdb
  • goleveldb

....all in one place, and that the only way to do that is to either fork cometbft-db or just use the latest version.

This PR:

fixes the dependency versioning only. I think that there are additional issues here in cometbft that prevent goleveldb from working correctly when used with cometbft v0.38.x and cometbft-db v0.13.0+

Activity

  1. faddat commented on Oct 15, 2024

    @faddat
    ContributorAuthor

    Notably, our "root cause" came from dependabot:

    It's my opinion that it's reasonable to think that users will want to use the latest cometbft-db dependency, and that this should be able to clean that up nicely.

  2. changed the title [-]bug: tx_search is reset to a single entry when using goleveldb[/-] [+]incompatiblity: tx_search is reset to a single entry when using goleveldb with cometbft v0.38.x[/+] on Oct 15, 2024
  3. andynog commented on Oct 15, 2024

    @andynog
    Contributor

    Hi @faddat, thanks for reporting this. In order for us to reproduce the problem, could you please provide a few more details on the tx_search is reset to a single entry statement?

    From what I understand is that when using tx_search you would expect to get multiple search results but only one entry is returned. Is that correct ?

    Is the tested performed using ComettBFT only or using a Cosmos-SDK binary pointing to a specific CometBFT release? (from what you said seems that anything that uses cometbft-db v0.13.0+)

  4. added
    needs-triageThis issue/PR has not yet been triaged by the team.
    on Oct 15, 2024
  5. added this to the 2024-Q4 milestone on Oct 15, 2024
  6. added
    needs-informationWaiting for additional information or feedback
    and removed
    needs-triageThis issue/PR has not yet been triaged by the team.
    on Oct 15, 2024
  7. moved this from Todo to In Progress in CometBFTon Oct 22, 2024
  8. self-assigned this
    on Oct 22, 2024
  9. andynog commented on Oct 22, 2024

    @andynog
    Contributor

    we are doing some extra tests too to try to reproduce the error, just FYI.

  10. added a commit that references this issue on Oct 23, 2024
    fc63ebf
  11. added 5 commits that reference this issue on Oct 24, 2024
    2fee473
    2197ae8
    b674402
    2424f7a
    f884c76
  12. andynog commented on Oct 24, 2024

    @andynog
    Contributor

    Fixed in #4321

  13. moved this from In Progress to Done in CometBFTon Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

dependenciesDependency updatesneeds-informationWaiting for additional information or feedback

Type

No type

Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions