Repository navigation
incompatiblity: tx_search is reset to a single entry when using goleveldb with cometbft v0.38.x #4295
Description
Activity
Notably, our "root cause" came from dependabot:
-
build(deps): Bump github.com/cometbft/cometbft-db from 0.9.5 to 1.0.1 #4214
-
build(deps): Bump github.com/cometbft/cometbft-db from 0.12.0 to 1.0.1 #4201
It's my opinion that it's reasonable to think that users will want to use the latest cometbft-db dependency, and that this should be able to clean that up nicely.
-
- changed the title
[-]bug: tx_search is reset to a single entry when using goleveldb[/-][+]incompatiblity: tx_search is reset to a single entry when using goleveldb with cometbft v0.38.x[/+]on Oct 15, 2024 Hi @faddat, thanks for reporting this. In order for us to reproduce the problem, could you please provide a few more details on the
tx_search is reset to a single entrystatement?From what I understand is that when using
tx_searchyou would expect to get multiple search results but only one entry is returned. Is that correct ?Is the tested performed using ComettBFT only or using a Cosmos-SDK binary pointing to a specific CometBFT release? (from what you said seems that anything that uses
cometbft-db v0.13.0+)- addeddependenciesDependency updatesDependency updatesneeds-triageThis issue/PR has not yet been triaged by the team.This issue/PR has not yet been triaged by the team.
on Oct 15, 2024 - addedneeds-informationWaiting for additional information or feedbackWaiting for additional information or feedbackand removedneeds-triageThis issue/PR has not yet been triaged by the team.This issue/PR has not yet been triaged by the team.
on Oct 15, 2024 we are doing some extra tests too to try to reproduce the error, just FYI.
- added a commit that references this issue
on Oct 23, 2024 - added 5 commits that reference this issue
on Oct 24, 2024 Fixed in #4321
- added a commit that references this issue
on Nov 4, 2024
Metadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsDone
Goleveldb (not pebble) is broken when using tx_search with cometbft v0.38.12 and cometbft-db v0.13.0+
I don't know if this happens in
mainor not.If users should not use cometbft-db > 0.12.x with cometbft v0.38.x, we should probably say that.
I think it is more likely that this breakage was unintentional, related to the contract changes mentioned in the release nodes for cometbft-db:
Note that users of cometbft v0.38.x may wish to use:
....all in one place, and that the only way to do that is to either fork cometbft-db or just use the latest version.
This PR:
fixes the dependency versioning only. I think that there are additional issues here in cometbft that prevent goleveldb from working correctly when used with cometbft v0.38.x and cometbft-db v0.13.0+