Skip to content

crypto/bls12381: Sign and Verify should use dstMinPk #4783

Description

@melekes

See berachain#11 (comment)

In #3860 we forgot to update the dst for signing and verifying operations. It should be dstMinPk, not dstMinSig because, currently, we're optimizing for the minimal public key.

Activity

  1. added
    bugSomething isn't working
    cryptoCryptography-related
    needs-triageThis issue/PR has not yet been triaged by the team.
    on Jan 7, 2025
  2. removed
    needs-triageThis issue/PR has not yet been triaged by the team.
    on Jan 10, 2025
  3. added a commit that references this issue on Jan 13, 2025
    b18f093
  4. self-assigned this
    on Jan 13, 2025
  5. moved this from Todo to Ready for Review in CometBFTon Jan 13, 2025
  6. added a commit that references this issue on Jan 23, 2025
    f2d9ae0
  7. moved this from Ready for Review to Done in CometBFTon Jan 23, 2025
  8. added 2 commits that reference this issue on Jan 23, 2025
    2a44e0e
    1fb89c8
  9. added a commit that references this issue on Sep 15, 2025
    3369b7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingcryptoCryptography-related

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions