Repository navigation
Support recursive globstar in path repositories - #13107
Open
truongbo17 wants to merge 1 commit into
Open
truongbo17 wants to merge 1 commit into
truongbo17 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12461.
PHP's
glob()treats**like a single*, so a path repository such asmodules/**misses packages nested more than one directory deep. This change expands a standalone**path segment over zero or more directories while retaining the existing glob behavior for the remaining path. It supports multiple recursive segments, deduplicates matches, and keeps their order deterministic.The regression test covers a nested package, a trailing
**, a package directly under a**/namepattern, and multiple recursive segments. The reproducer from the issue now resolves the nested package.Local checks:
PathRepositoryTest: 10 tests, 34 assertions passed.