Skip to content

fix unescaped double-quotes for defines - #10008

Merged
memsharded merged 1 commit into
conan-io:developfrom
Enhex:patch-2
Nov 14, 2021
Merged

fix unescaped double-quotes for defines#10008
memsharded merged 1 commit into
conan-io:developfrom
Enhex:patch-2

Conversation

@Enhex

@Enhex Enhex commented Nov 12, 2021 •
edited by czoido
Loading

Copy link
Copy Markdown
Contributor

Changelog: Bugfix: Fix unescaped double-quotes for defines in Premake generator.
Docs: Omit

boost/1.77.0 generates unescaped double-quotes:

conan_defines = {"BOOST_STACKTRACE_ADDR2LINE_LOCATION="/usr/bin/addr2line"",

the Premake generator didn't escape double-quotes for defines, so this PR fixes that.

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@memsharded memsharded added this to the 1.43 milestone Nov 14, 2021
@memsharded

memsharded commented Nov 14, 2021

Copy link
Copy Markdown
Member

Please recall that Premake is considered a legacy generator. It needs to be modernized into https://docs.conan.io/en/latest/reference/conanfile/tools.html first in order to be ready to move forward to 2.0

@memsharded
memsharded merged commit f31fdba into conan-io:develop Nov 14, 2021
@Enhex

Enhex commented Nov 15, 2021

Copy link
Copy Markdown
Contributor Author

I'm unfamiliar with the Conan 2.0 tools, is there any guide that I can use for creating a Premake one?

@memsharded

memsharded commented Nov 15, 2021

Copy link
Copy Markdown
Member

I'm unfamiliar with the Conan 2.0 tools, is there any guide that I can use for creating a Premake one?

The source code for the other generators in the new conan.tools.cmake, (note the singular "conan") and conan.tools.microsoft etc are the ones to check. There is no explicit guide but:

  • They should use self.dependencies, not self.deps_cpp_info
  • they don't extend any class, implement generate() method
  • If possible they should generate 1 file (or set of files) per dependency
  • If possible they should handle multi-configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.43

Development

Successfully merging this pull request may close these issues.

2 participants

@Enhex @memsharded