[bugfix] msvc in legacy cmake generators - #10195
Merged
lasote merged 2 commits intoDec 20, 2021
Merged
Conversation
franramirez688
requested review from
czoido,
jgsogo,
lasote and
memsharded
and removed request for
jgsogo
December 17, 2021 15:43
Contributor
Author
|
TODO: one functional test with UPDATE: Done |
memsharded
approved these changes
Dec 17, 2021
Contributor
|
I think it's okay if the legacy generator doesn't support a new compiler, as we discussed in #9370. they are going to die very soon anyway. |
Contributor
|
The problem is with conan-center, before introducing the new generators we are breaking every recipe just because we now detect the |
czoido
approved these changes
Dec 20, 2021
|
PLEASE explain how we are supposed to build a project today in a stable way with vs2022. |
Member
|
How do I configure ninja and msvc?
Chemical & Biological Engineer
periodic wizbang
…On Sun, Feb 20, 2022, 9:17 AM James ***@***.***> wrote:
@LeeRuns <https://github.com/LeeRuns> please check the release notes,
this was fixed in #10457 <#10457>
for 1.45, it is now detecting by default Visual Studio instead msvc.
And in any case, using the automatically detected profiles is not
recommended for production, but using your own profile, which can define compiler="Visual
Studio"
—
Reply to this email directly, view it on GitHub
<#10195 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADZNMPRVAQHN73E25X3GXB3U4EHY5ANCNFSM5KJEJ4GA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
|
@LeeRuns the modern integrations require very little configuration. Basically this works: $ conan new hello/0.1 --template=cmake_lib
$ conan create . -c tools.cmake.cmaketoolchain:generator=NinjaThis builds with Visual Studio and Ninja generator, both the package and the consumer project inside the |
|
Ok, thanks for the clarification.
…On Mon, Feb 21, 2022, 3:14 PM James ***@***.***> wrote:
@LeeRuns <https://github.com/LeeRuns> the modern integrations require
very little configuration. Basically this works:
$ conan new hello/0.1 --template=cmake_lib
$ conan create . -c tools.cmake.cmaketoolchain:generator=Ninja
This builds with Visual Studio and Ninja generator, both the package and
the consumer project inside the test_package folder.
—
Reply to this email directly, view it on GitHub
<#10195 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADZNMPVHXMO2I6Y5PLIKANTU4K2K7ANCNFSM5KJEJ4GA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Compiler
msvcwas not working for CMake legacy generators.Docs: omit
Closes: #10185
developbranch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.