Allow --output-folder and --source-folder in editables and install/build cmds - #10274
Merged
franramirez688 merged 30 commits intoJan 26, 2022
Conversation
franramirez688
approved these changes
Jan 21, 2022
| if source_folder is not None: | ||
| source_folder = _make_abs_path(source_folder) | ||
| if build_folder is not None: | ||
| build_folder = _make_abs_path(build_folder) |
Contributor
There was a problem hiding this comment.
You can pass for both _make_abs_path methods cwd as the second argument.
lasote
suggested changes
Jan 24, 2022
lasote
approved these changes
Jan 25, 2022
czoido
approved these changes
Jan 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Adding
--source-folderand--output-foldertoconan editableandconan installto work withlayout().Docs: conan-io/docs#2377
Followup of #10207
Superseded and deprecated previous PR #10180