Add quotes around conan_message output variable so it is not modified - #10388
Merged
Merged
Conversation
conan_message output variable so it is not modified
jgsogo
commented
Jan 20, 2022
| function(conan_message MESSAGE_TYPE MESSAGE_CONTENT) | ||
| if(NOT CONAN_CMAKE_SILENT_OUTPUT) | ||
| message(${MESSAGE_TYPE} ${MESSAGE_CONTENT}) | ||
| message(${MESSAGE_TYPE} "${MESSAGE_CONTENT}") |
Contributor
Author
There was a problem hiding this comment.
Without quotes, it removes the ; from lists... which can be very confusing when you are focused on an issue related to a list of paths 😄
jgsogo
commented
Jan 20, 2022
| return '"%s"' % ";".join(p.replace('\\', '/').replace('$', '\\$') for p in values) | ||
|
|
||
| self.include_paths = join_paths(cpp_info.includedirs) | ||
| self.include_path = join_paths_single_var(cpp_info.includedirs) |
Contributor
Author
There was a problem hiding this comment.
This one is not used in the template (but I didn't check the if it is used in the rest of the codebase)
Member
There was a problem hiding this comment.
Indeed seems unused, no prob
memsharded
approved these changes
Jan 20, 2022
| return '"%s"' % ";".join(p.replace('\\', '/').replace('$', '\\$') for p in values) | ||
|
|
||
| self.include_paths = join_paths(cpp_info.includedirs) | ||
| self.include_path = join_paths_single_var(cpp_info.includedirs) |
Member
There was a problem hiding this comment.
Indeed seems unused, no prob
Contributor
|
Relaunched CI, failed because of the weird language change in Windows CI. |
lasote
approved these changes
Jan 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Add quotes around
conan_messageoutput variable so it is not modified.Docs: omit