Remove default Frameworks - #11455
Merged
memsharded merged 2 commits intoJun 15, 2022
Merged
Conversation
memsharded
approved these changes
Jun 14, 2022
memsharded
left a comment
Member
There was a problem hiding this comment.
Seems this is fine, as it is protected by the layout() existence opt-in
lasote
marked this pull request as ready for review
June 15, 2022 06:14
lasote
marked this pull request as draft
June 15, 2022 06:17
Contributor
Author
|
I'll double-check that the default |
lasote
marked this pull request as ready for review
June 15, 2022 06:26
memsharded
approved these changes
Jun 15, 2022
This was referenced Jun 15, 2022
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: When using the new layout() feature of Conan 2.0, change the default
cpp_info.frameworkdirs = ["Frameworks"]tocpp_info.frameworkdirs = [], because it is more common to not have packaged Apple frameworks and declaring a missing folder can cause issues with the new toolchains.Docs: conan-io/docs#2613