Simplify XcodeDeps generator - #11491
Merged
Merged
Conversation
memsharded
approved these changes
Jun 21, 2022
franramirez688
approved these changes
Jun 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Simplify XcodeDeps generator.
Docs: conan-io/docs#2619
This PR removes a file containing variables that was included from other file, the contents of these two files can be merged. It is also removing _BINARY_DIRECTORIES and _RESOURCE_DIRECTORIES because those were not used in the xcconfig files and it's not clear to which Xcode variable can be added, if there's one.
This is a preliminar step to another upcoming PR that will try to adress the problem that libraries with components that have lots of dependencies between components make xcode crash because of adding too many duplicated include paths and so on...