validate_build over settings - #11580
Merged
czoido merged 8 commits intoJul 12, 2022
Merged
Conversation
memsharded
reviewed
Jul 6, 2022
memsharded
left a comment
Member
There was a problem hiding this comment.
Too many tests are broken, but I fail to see how these changes can cause that breakage
lasote
commented
Jul 7, 2022
memsharded
reviewed
Jul 7, 2022
lasote
marked this pull request as ready for review
July 12, 2022 11:12
memsharded
approved these changes
Jul 12, 2022
memsharded
left a comment
Member
There was a problem hiding this comment.
Looks good.
Don't forget to mark it as experimental in the docs
czoido
approved these changes
Jul 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Introduced a
validate_build()method in the recipes to validate if the package can be built according toself.settingsandself.optionsinstead ofself.info.settingsandself.info.optionsthat it is used to validate thebinary.Docs: conan-io/docs#2667