Escape quotes for XCodeDeps generator - #11039
Merged
Merged
Conversation
|
I would recommend using |
Member
But this is for an Xcode build file, not for terminal: Are the xcode build scripts variable values supposed to be escaped following the shell escaping? |
|
I thought it worked the same way as a .pc file, just copy pasting the variable into a command line |
Member
I think Xcode is a more advanced and complex build system and does many other things, beyond what a .pc /pkg-config does, that was the reason of my question. Maybe the best is to keep the current proposal of just scaping the quotes, and not the full shlex.quote alternative. |
memsharded
approved these changes
Apr 19, 2022
This was referenced Apr 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Escape quotes in XCodeDeps generator.
Docs: omit
Testing the imgui recipe from Conan Center looks like XCode won't accept the defines generated in the xcconfig files because quote character is not properly escaped.
Related to: #11013