self.export_source_folder (based on layout.py) - #11055
Merged
memsharded merged 5 commits intoApr 20, 2022
Merged
Conversation
lasote
commented
Apr 20, 2022
memsharded
reviewed
Apr 20, 2022
memsharded
left a comment
Member
There was a problem hiding this comment.
I think your approach is cleaner than mine, because it is a full implementation (solving my open TODOs) following layout. I will close my PR.
lasote
marked this pull request as ready for review
April 20, 2022 15:36
memsharded
approved these changes
Apr 20, 2022
memsharded
left a comment
Member
There was a problem hiding this comment.
Clean and clear, looks ready to go!
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Renamed
self.base_source_foldertoself.export_source_folder. That variable was introduced to reference the folder where theexport_sourcesare. Currently, they are copied to thesourcefolder but might be changed in the future to avoid copying them, soself.export_source_folderwill always point to the folder containing theexports_sources.Docs: conan-io/docs#2514
Similar than #11053
Close #10643
Warn: The
update_conandatacheck is not possible anymore with this implementation.