Conversation
kkpattern
force-pushed
the
fix/shared-lib-on-windows-should-use-interface
branch
from
May 28, 2022 14:29
0f433c5 to
154d301
Compare
kkpattern
force-pushed
the
fix/shared-lib-on-windows-should-use-interface
branch
from
May 29, 2022 11:52
154d301 to
48fcc63
Compare
memsharded
approved these changes
May 29, 2022
memsharded
left a comment
Member
There was a problem hiding this comment.
This is looking nice and clean (despite the problem is intrinsically a bit complex, given the context information), so thanks very much for contributing it.
lasote
approved these changes
May 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Use
interface_librarywithshared_libraryon Windows in BazelDeps.Docs: omit
Close: #11347
When importing shared libraries, check if there is a corresponding DLL file in the bin directory. If the DLL file exists, we should use
cc_importof the form:Bazel doc here.
I also added a new
MockConanFileDepsto avoid the infinite loop in unittest(No need to patch theconans.ConanFile.dependeciesfor all).Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.