Solving conf_info from BR inherited by consumers' test_package - #12095
Merged
Merged
Conversation
memsharded
reviewed
Sep 13, 2022
memsharded
left a comment
Member
There was a problem hiding this comment.
I'd say this is looking good, but there are a bunch of tests broken, it is not evident what is happening, should be investigated
Contributor
Author
Yes, I saw. I think I shouldn't override the |
franramirez688
approved these changes
Sep 14, 2022
Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>
memsharded
approved these changes
Sep 21, 2022
Closed
4 tasks
This was referenced Oct 18, 2022
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Fixed a bug when getting the values from the
self.confin the conanfile of atest_packagewith build_requirements declaring theself.conf_info.Docs: omit
The issue is in conan 1.x , the test_package conanfile cannot read (loses) the
confinherited from the build requires.It works for 2.x BUT this is a conan-center-index recipes migration issue so we should provide the fix.
Closes #11975