Skip to content

add support for windows on ARM64 native platform - #12145

Merged
memsharded merged 4 commits into
conan-io:developfrom
microblink:feature/woa64
Sep 21, 2022
Merged

memsharded merged 4 commits into
conan-io:developfrom
microblink:feature/woa64

Conversation

@DoDoENT

@DoDoENT DoDoENT commented Sep 19, 2022

Copy link
Copy Markdown
Contributor

Changelog: Fix: Add support for windows on ARM64 native platform.
Docs: omit

Closes: #12144

'x86_64': 'x86_amd64',
'armv7': 'x86_arm',
'armv8': 'x86_arm64'}.get(arch_setting)
elif arch_build == 'armv8':

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is modifying only the legacy tool from conans
This should be done as a secondary thing, as a backport, but this should be addressed first in from conan space.

Also some unittest would be necessary, please ask for guidance if you need it.
Thanks for contributing to Conan!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pointers. I've added the same code also for non-legacy from conan.

I've also updated the only unit test I found that deals with testing the vcvars, but it also works with the legacy from conans. Also, how to run just this single test? I've run python3 -m tox -e full as described in the documentation and more than 1400 tests have failed, most of them completely unrelated to my change. Are they supposed to fail?

Comment thread conans/test/functional/tools/old/vcvars/vcvars_arch_test.py Outdated
Comment thread conans/test/functional/tools/old/vcvars/vcvars_arch_test.py Outdated
@memsharded memsharded added this to the 1.53 milestone Sep 21, 2022
@memsharded
memsharded merged commit 669a1b7 into conan-io:develop Sep 21, 2022
@DoDoENT
DoDoENT deleted the feature/woa64 branch September 21, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] ConanException: unsupported architecture armv8 on Windows on ARM

2 participants