Overwrite deactivate script to unset only the last activated virtual environment (#12344) - #12353
Merged
memsharded merged 2 commits intoOct 27, 2022
Merged
memsharded merged 2 commits into
memsharded merged 2 commits into
Conversation
|
|
Member
|
Hi @Bearwolves Thanks for your contribution. Don't worry too much about the tests, we can help adding some. |
…environment (#12344) * Align with windows behavior (save_bat())
memsharded
approved these changes
Oct 27, 2022
memsharded
marked this pull request as ready for review
October 27, 2022 12:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Overwrite deactivate script to unset only the last activated virtual environment.
Docs: omit
fixes #12344
No idea how to add a unit test to check that there is no duplication of the echo message.
I had a look at:
https://github.com/conan-io/conan/blob/develop/conans/test/integration/environment/test_env.py
https://github.com/conan-io/conan/blob/develop/conans/test/integration/build_requires/test_install_test_build_require.py#L183-L190
Refer to the issue that supports this Pull Request.
If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
I've read the Contributing guide.
I've followed the PEP8 style guides for Python code.
I've opened another PR in the Conan docs repo to the
developbranch, documenting this one.