Fix issue extracting install name from universal dylib - #13034
Merged
memsharded merged 1 commit intoFeb 8, 2023
Merged
Conversation
czoido
approved these changes
Feb 2, 2023
jcar87
marked this pull request as ready for review
February 2, 2023 17:10
Contributor
|
I don't think it's guaranteed values are always the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Fix issue in
fix_apple_shared_install_namehandling dylib files with multiple architectures (universal).Docs: Omit
Close: #13014
The
otool -Dcommand will report the install name multiple times fordylibfiles that have multiple architectures (universal binaries). In practice, the values should be the same: this PR causes it to pick the first one encountered. When subsequently callinginstall_name_tool, it will be correctly replaced in all architectures anyway.