Add prefix to pkgconfig root - #14051
Conversation
This is useful for meson, to get the path of the installed package
f49561f to
0610516
Compare
memsharded
left a comment
There was a problem hiding this comment.
Looks good, thanks!
Assigning @franramirez688 for final review
|
Thanks for the contribution @bruchar1 I'm wondering why this is needed. Which is the use case? Was it actually a bug? |
This is detailed in the linked issue. The fact the prefix variable is not in the .pc file is not really a bug, but having it solves issues with meson integration, especially because meson needs this variable to know where the package is installed. The fact |
Oh, so sorry, my fault, I did not realize about the issue. Let me have a look at it. Perhaps, it makes sense to add a dedicated test for this change. |
| # Custom PC content | ||
|
|
||
| datadir=${{prefix}}/share | ||
| schemasdir=${{datadir}}/mylib/schemas |
There was a problem hiding this comment.
Added this extra check to ensure that the custom content is being added only to the root .pc file.
Changelog: Bugfix: Add prefix var and any custom content (through the
pkg_config_custom_contentproperty) to already generated pkg-config root .pc files byPkgConfigDeps.Docs: omit
Fixes #14049