[CMakeToolchain] fix adding tools.android:ndk_path with spaces in path - #17379
Merged
Merged
Conversation
|
|
memsharded
reviewed
Nov 25, 2024
memsharded
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution!
Test test_android_c_library is broken in CI, it seems it is testing the output literally, so it should be updated.
Contributor
Author
|
thanks, you're absolutely right! Updated the test. |
memsharded
approved these changes
Nov 25, 2024
AbrilRBS
approved these changes
Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Fix adding
tools.android:ndk_pathwith spaces in path.Docs: Omit
Closes: #17378
developbranch, documenting this one.