fixing CMakeConfigDeps INTERFACE IMPORTED_CONFIGURATIONS - #18088
Merged
memsharded merged 1 commit intoApr 8, 2025
Merged
memsharded merged 1 commit into
memsharded merged 1 commit into
Conversation
This was referenced Apr 6, 2025
| assert "protobuf: Release!" in c.out | ||
|
|
||
|
|
||
| @pytest.mark.tool("cmake", "3.23") |
Contributor
There was a problem hiding this comment.
Do we require 3.27 for CMakeConfigDeps as the minimum-required-version?
Member
Author
There was a problem hiding this comment.
It is necessary to proof that it works without the CMAKE_MAP_IMPORTED_CONFIGURATIONS for CMake>=3.27
jcar87
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Add IMPORTED_CONFIGURATIONS to INTERFACE libraries to in
CMakeConfigDepsDocs: Omit
Close #18058