- allow vcvars for clang-cl - #3574
Merged
Merged
Conversation
danimtb
reviewed
Sep 19, 2018
SSE4
force-pushed
the
vcvars_clangcl
branch
from
September 19, 2018 12:02
51b0a2a to
6b59c11
Compare
Signed-off-by: SSE4 <tomskside@gmail.com>
lasote
approved these changes
Sep 20, 2018
lasote
left a comment
Contributor
There was a problem hiding this comment.
My only concern is the breaking behavior, but prior to this PR, passing a non-visual studio compiler with whatever version could have unexpected results. So for me is ok.
danimtb
approved these changes
Sep 20, 2018
jgsogo
suggested changes
Sep 22, 2018
jgsogo
left a comment
Contributor
There was a problem hiding this comment.
I will add also a test mocking the function vs_installation_path in order to test the new if/else clauses.
lasote
suggested changes
Sep 24, 2018
…the latest_visual_studio_version_installed Signed-off-by: SSE4 <tomskside@gmail.com>
Signed-off-by: SSE4 <tomskside@gmail.com>
Signed-off-by: SSE4 <tomskside@gmail.com>
Contributor
Author
jgsogo
suggested changes
Sep 24, 2018
Signed-off-by: SSE4 <tomskside@gmail.com>
Signed-off-by: SSE4 <tomskside@gmail.com>
lasote
approved these changes
Sep 25, 2018
Contributor
|
Pending to open a PR in the docs with:
|
Contributor
Signed-off-by: SSE4 <tomskside@gmail.com>
Contributor
Author
|
made |
danimtb
requested changes
Sep 26, 2018
danimtb
left a comment
Member
There was a problem hiding this comment.
I see the value of having a _system_registry_key() function and it will come handy in some other detections and checks but we have to reduce the complexity of its usage
Signed-off-by: SSE4 <tomskside@gmail.com>
Signed-off-by: SSE4 <tomskside@gmail.com>
danimtb
approved these changes
Sep 26, 2018
danimtb
left a comment
Member
There was a problem hiding this comment.
LGTM, just small changes required 😃
Signed-off-by: SSE4 <tomskside@gmail.com>
Try/catch for OpenKey and for QueryValue
jgsogo
suggested changes
Sep 26, 2018
Signed-off-by: SSE4 <tomskside@gmail.com>
jgsogo
approved these changes
Sep 26, 2018
grisumbras
pushed a commit
to grisumbras/conan
that referenced
this pull request
Dec 27, 2018
* - allow vcvars for clang-cl Signed-off-by: SSE4 <tomskside@gmail.com> * - move _visual_compiler_last from detect.py into win.py, renaming to the latest_visual_studio_version_installed Signed-off-by: SSE4 <tomskside@gmail.com> * - look from the latest to oldest Signed-off-by: SSE4 <tomskside@gmail.com> * - add negative test case Signed-off-by: SSE4 <tomskside@gmail.com> * - handle latest_visual_studio_version_installed returns None Signed-off-by: SSE4 <tomskside@gmail.com> * - add system_registry_key context manager, ensure key is always closed Signed-off-by: SSE4 <tomskside@gmail.com> * - make system_registry_key private Signed-off-by: SSE4 <tomskside@gmail.com> * - return just Visual Studio version Signed-off-by: SSE4 <tomskside@gmail.com> * - simplify _system_registry_key Signed-off-by: SSE4 <tomskside@gmail.com> * - remove decorator Signed-off-by: SSE4 <tomskside@gmail.com> * try/catch for openKey and for QueryValue * - set detected compiler tuple properly Signed-off-by: SSE4 <tomskside@gmail.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: SSE4 tomskside@gmail.com
related to the:
#1839
https://github.com/conan-community/community/issues/43
developbranch, documenting this one. Also adding a description of the changes in thechangelog.rstfile. https://github.com/conan-io/docsChangelog: Feature: Allow
vcvarsto run ifclang-clcompiler is detected.