Skip to content

#3649 Update CI templates - #3651

Merged
lasote merged 7 commits into
conan-io:developfrom
uilianries:feature/update-gitlab
Oct 26, 2018
Merged

#3649 Update CI templates#3651
lasote merged 7 commits into
conan-io:developfrom
uilianries:feature/update-gitlab

Conversation

@uilianries

@uilianries uilianries commented Oct 1, 2018 •
edited by lasote
Loading

Copy link
Copy Markdown
Member

Hi this PR brings some updates related to issue #3649 :

  • CONAN_REFERENCE is no longer required
  • Add GCC 8 on default CI template list
  • Add Clang 5, 6 on default CI template list
  • Update unit test to avoid CONAN_REFERENCE

closes #3649

Changelog: Fix: Updated templates of the conan new command with the latest conan package tools changes.

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@uilianries
conan-io#3649 Update CI templates
c21b1ab 
- CONAN_REFERENCE is no longer required
- Add GCC 8 on default CI template list
- Add Clang 5, 6 on default CI template list
- Update unit test to avoid CONAN_REFERENCE

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@ghost ghost added the contributor pr label Oct 1, 2018
danimtb
danimtb approved these changes Oct 1, 2018
View reviewed changes

@danimtb danimtb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed due to Mac slaves not working

@uilianries

uilianries commented Oct 1, 2018

Copy link
Copy Markdown
Member Author

My changes didn't affect Macos jobs 🤔

infrastructure error?

@danimtb

danimtb commented Oct 1, 2018

Copy link
Copy Markdown
Member

yes, that is what I meant

@uilianries
conan-io#3649 Update Conan Package Tools template
603c2fe 
- User new CPT import

Signed-off-by: Uilian Ries <uilianries@gmail.com>
lasote
lasote reviewed Oct 8, 2018
View reviewed changes
Comment thread conans/client/cmd/new_ci.py
@lasote lasote added this to the 1.9 milestone Oct 8, 2018
@uilianries
conan-io#3649 Revert Conan reference in new CI
806fce7 
- Conan reference is mandatory when the recipe does not contain
  name and version.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@lasote

lasote commented Oct 9, 2018

Copy link
Copy Markdown
Contributor

Should we add clang 7?

@Croydon

Croydon commented Oct 9, 2018

Copy link
Copy Markdown
Contributor

We should first solve the discussion around the new Clang 7 version schema I guess.

@uilianries

uilianries commented Oct 9, 2018

Copy link
Copy Markdown
Member Author

Did you mean #3643 ?

@Croydon

Croydon commented Oct 9, 2018

Copy link
Copy Markdown
Contributor

Did you mean #3643 ?

Yes

danimtb
danimtb requested changes Oct 19, 2018
View reviewed changes

@danimtb danimtb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update Appveyor CI template to use Python 3 instead of python 2

@Croydon

Croydon commented Oct 19, 2018

Copy link
Copy Markdown
Contributor

I can't see any change related to

CONAN_REFERENCE is no longer required

🤔

@uilianries

uilianries commented Oct 19, 2018

Copy link
Copy Markdown
Member Author

I can't see any change related to

CONAN_REFERENCE is no longer required

thinking

I removed at first moment, but I reverted after Lasote request:

806fce7

@uilianries
conan-io#3649 Update appveyor template to run python3
a6b90c3 
- Replace Python27 by Python37. Both Python arch and version are no
longer required.
- Update Travis using Xenial as base image

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries

uilianries commented Oct 19, 2018

Copy link
Copy Markdown
Member Author

@danimtb

Please update Appveyor CI template to use Python 3 instead of python 2

Done!

@Croydon

Croydon commented Oct 19, 2018

Copy link
Copy Markdown
Contributor

Could you also please update the container names to conanio/<compiler><compiler-version>? It seems still to use the old names

@uilianries

uilianries commented Oct 19, 2018

Copy link
Copy Markdown
Member Author

Could you also please update the container names to conanio/<compiler><compiler-version>? It seems still to use the old names

sure! thanks for reviewing.

@uilianries
conan-io#3649 Update docker image names
1841836 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries

uilianries commented Oct 19, 2018

Copy link
Copy Markdown
Member Author

@Croydon Done!

Croydon
Croydon approved these changes Oct 19, 2018
View reviewed changes

@Croydon Croydon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uilianries

uilianries commented Oct 19, 2018

Copy link
Copy Markdown
Member Author

I forgot to update the tests 🤦‍♂️

@uilianries
conan-io#3649 Update unit test for new CI
ab8456b 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@lasote lasote mentioned this pull request Oct 26, 2018
Closed
3 tasks
@lasote
lasote merged commit 6887698 into conan-io:develop Oct 26, 2018
@ghost ghost removed the stage: review label Oct 26, 2018
grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018
@uilianries @lasote
conan-io#3649 Update CI templates (conan-io#3651)
208f889 
* conan-io#3649 Update CI templates

- CONAN_REFERENCE is no longer required
- Add GCC 8 on default CI template list
- Add Clang 5, 6 on default CI template list
- Update unit test to avoid CONAN_REFERENCE

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* conan-io#3649 Update Conan Package Tools template

- User new CPT import

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* conan-io#3649 Revert Conan reference in new CI

- Conan reference is mandatory when the recipe does not contain
  name and version.

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* conan-io#3649 Update appveyor template to run python3

- Replace Python27 by Python37. Both Python arch and version are no
longer required.
- Update Travis using Xenial as base image

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* conan-io#3649 Update docker image names

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* conan-io#3649 Update unit test for new CI

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danimtb danimtb danimtb approved these changes
+2 more reviewers
@Croydon Croydon Croydon approved these changes
@lasote lasote lasote approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lasote lasote

Labels

None yet

Projects

None yet

Milestone

1.9

Development

Successfully merging this pull request may close these issues.

Update Gitlab CI template

4 participants

@uilianries @danimtb @lasote @Croydon