Do not allow wildcards in 'conan download' command - #3843
Merged
Merged
Conversation
memsharded
approved these changes
Oct 24, 2018
memsharded
left a comment
Member
There was a problem hiding this comment.
good! See the comment, change if you feel to, or leave it as-is, both good, and merge.
| from conans.model.version import Version | ||
|
|
||
|
|
||
| def check_valid_ref(ref, allow_pattern=False): |
Member
There was a problem hiding this comment.
allow_pattern is always False, then so far it is a bit speculative, isn't it?
Contributor
Author
There was a problem hiding this comment.
Maybe it is better not to provide a default, I'll change it.
danimtb
approved these changes
Oct 24, 2018
grisumbras
pushed a commit
to grisumbras/conan
that referenced
this pull request
Dec 27, 2018
* do not allow wildcards in download * remove default variable value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: do not allow wildcards in command
conan download <ref-without-wildcards>