Do not ask for username if it is already given - #3839
Merged
Merged
Conversation
danimtb
approved these changes
Oct 24, 2018
Member
|
I was thinking about this and previous PR introduced some tests that are passing now, so maybe this was not covered by them. Is it possible to include something testing this @jgsogo? |
Contributor
Author
|
Here you have your test ;D |
grisumbras
pushed a commit
to grisumbras/conan
that referenced
this pull request
Dec 27, 2018
Do not ask for username if it is already given
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: do not ask for the username if it is already given when login into a remote.
These lines were modified in this PR #3464 to v1.8, and the previous behavior altered.