Fix: Update premake generator, rename conanbuildinfo.premake -> conanbuildinfo.premake.lua, conan_cppdefines -> conan_defines - #4296
Merged
Conversation
Signed-off-by: SSE4 <tomskside@gmail.com>
…xxflags Signed-off-by: SSE4 <tomskside@gmail.com>
danimtb
requested changes
Jan 15, 2019
danimtb
left a comment
Member
There was a problem hiding this comment.
Suggestions according to #4286 (comment)
Member
|
Please make a PR to the docs with this new information and provide a meaningful changelog (important as this would be """breaking""" for premake users) |
Contributor
|
ping @SSE4 missing docs |
Contributor
Contributor
Author
|
@SSE4 no, I'll add docs ASAP |
Contributor
Author
|
added docs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4286
Changelog: Fix: Update premake generator, rename conanbuildinfo.premake -> conanbuildinfo.premake.lua, conan_cppdefines -> conan_defines
Docs: conan-io/docs#1032
developbranch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.
/cc @solvingj